dragosmg commented on code in PR #13160:
URL: https://github.com/apache/arrow/pull/13160#discussion_r873690761
##########
r/R/dplyr-funcs.R:
##########
@@ -58,15 +58,16 @@ NULL
#' @keywords internal
#'
register_binding <- function(fun_name, fun, registry = nse_funcs) {
- name <- gsub("^.*?::", "", fun_name)
+ name <- gsub("^.*?_", "", fun_name)
namespace <- gsub("::.*$", "", fun_name)
Review Comment:
I went for what I see as a simpler approach as it's easier to think about
and execute an expression when it doesn't contain the `::` operator. Do you see
any shortcomings to my proposed approach? (other than the need for
"namespacing" internal / arrow functions?)
##########
r/R/dplyr-funcs.R:
##########
@@ -58,15 +58,16 @@ NULL
#' @keywords internal
#'
register_binding <- function(fun_name, fun, registry = nse_funcs) {
- name <- gsub("^.*?::", "", fun_name)
+ name <- gsub("^.*?_", "", fun_name)
namespace <- gsub("::.*$", "", fun_name)
Review Comment:
I went for what I see as a simpler approach as it's easier to think about
and execute an expression when it doesn't contain the `::` operator. Do you see
any shortcomings to my proposed approach? (other than the need for
"namespacing" internal / arrow functions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
