dragosmg commented on code in PR #13160:
URL: https://github.com/apache/arrow/pull/13160#discussion_r873665067
##########
r/R/dplyr-funcs.R:
##########
@@ -58,15 +58,16 @@ NULL
#' @keywords internal
#'
register_binding <- function(fun_name, fun, registry = nse_funcs) {
- name <- gsub("^.*?::", "", fun_name)
+ name <- gsub("^.*?_", "", fun_name)
namespace <- gsub("::.*$", "", fun_name)
Review Comment:
* The `namespace` variable existed previously, I haven't touched it. I
assume it was added for potential future use. I think it could be removed once
we support the `package::` prefix.
* We could introduce an `arrow` specific prefix. This could be either
`arrow_` or `internal_`. In which case both `arrow_fun_name` and `fun_name`
would be registered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
