thisisnic commented on code in PR #13160:
URL: https://github.com/apache/arrow/pull/13160#discussion_r873687746
##########
r/R/dplyr-funcs.R:
##########
@@ -58,15 +58,16 @@ NULL
#' @keywords internal
#'
register_binding <- function(fun_name, fun, registry = nse_funcs) {
- name <- gsub("^.*?::", "", fun_name)
+ name <- gsub("^.*?_", "", fun_name)
namespace <- gsub("::.*$", "", fun_name)
Review Comment:
Sure - I guess what I'm envisioning involves being able to achieve that but
via `registry` being more complicated than a named list, so some object which
has the function's name, namespace, and the function body itself, **but** I'm
not advocating for unnecessarily complicating things this way without good
reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
