jonkeane commented on code in PR #13160:
URL: https://github.com/apache/arrow/pull/13160#discussion_r874087967
##########
r/R/dplyr-funcs.R:
##########
@@ -58,15 +58,16 @@ NULL
#' @keywords internal
#'
register_binding <- function(fun_name, fun, registry = nse_funcs) {
- name <- gsub("^.*?::", "", fun_name)
+ name <- gsub("^.*?_", "", fun_name)
namespace <- gsub("::.*$", "", fun_name)
Review Comment:
Nic is absolutely right here, let's think about the design here. Especially
using underscores, which are not reserved so could cause clashes | weird design
decisions like they are pointing out.
You might also look at the PR that added much of this code — there's
discussion in there that is super helpful:
https://github.com/apache/arrow/pull/11904#issuecomment-999258101 I'm sure
you've read it as well, but there's some really good content in the jira
comments as well (along with some sketches).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
