tustvold commented on code in PR #2578: URL: https://github.com/apache/arrow-datafusion/pull/2578#discussion_r884786799
########## datafusion/core/src/datasource/object_store.rs: ########## @@ -0,0 +1,206 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! ObjectStoreRegistry holds all the object stores at Runtime with a scheme for each store. +//! This allows the user to extend DataFusion with different storage systems such as S3 or HDFS +//! and query data inside these systems. + +use datafusion_common::{DataFusionError, Result}; +use datafusion_data_access::object_store::local::{LocalFileSystem, LOCAL_SCHEME}; +use datafusion_data_access::object_store::ObjectStore; +use parking_lot::RwLock; +use std::collections::HashMap; +use std::sync::Arc; +use url::Url; + +/// A parsed URL identifying a particular [`ObjectStore`] +#[derive(Debug, Clone)] +pub struct ObjectStoreUrl { + url: Url, +} + +impl ObjectStoreUrl { + /// Parse an [`ObjectStoreUrl`] from a string + pub fn parse(s: impl AsRef<str>) -> Result<Self> { + let mut parsed = + Url::parse(s.as_ref()).map_err(|e| DataFusionError::External(Box::new(e)))?; + + let remaining = &parsed[url::Position::BeforePath..]; + if !remaining.is_empty() && remaining != "/" { + return Err(DataFusionError::Execution(format!( + "ObjectStoreUrl must only contain scheme and authority, got: {}", Review Comment: Authority refers to the entire section, and may contain just a hostname, or also username, password, port, etc... I figured it made sense to hedge for future functionality -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
