tustvold commented on code in PR #2578: URL: https://github.com/apache/arrow-datafusion/pull/2578#discussion_r877015064
########## datafusion/core/src/lib.rs: ########## @@ -52,11 +52,11 @@ //! .to_string(); //! //! let expected = vec![ -//! "+---+--------------------------+", -//! "| a | MIN(tests/example.csv.b) |", -//! "+---+--------------------------+", -//! "| 1 | 2 |", -//! "+---+--------------------------+" +//! "+---+----------------+", +//! "| a | MIN(?table?.b) |", Review Comment: I'm not entirely sure what change caused this... I wonder if we aren't running doctests in CI :thinking: Edit it is because of https://github.com/apache/arrow-datafusion/pull/2578/files#diff-e9c2d69b5793675f76c48aee263e29006065f1b28c50f056ccc6efe7d062aa77L611, this makes CSV consistent with other formats, which is probably a good thing ########## datafusion/core/src/lib.rs: ########## @@ -52,11 +52,11 @@ //! .to_string(); //! //! let expected = vec![ -//! "+---+--------------------------+", -//! "| a | MIN(tests/example.csv.b) |", -//! "+---+--------------------------+", -//! "| 1 | 2 |", -//! "+---+--------------------------+" +//! "+---+----------------+", +//! "| a | MIN(?table?.b) |", Review Comment: I'm not entirely sure what change caused this... I wonder if we aren't running doctests in CI :thinking: Edit: it is because of https://github.com/apache/arrow-datafusion/pull/2578/files#diff-e9c2d69b5793675f76c48aee263e29006065f1b28c50f056ccc6efe7d062aa77L611, this makes CSV consistent with other formats, which is probably a good thing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
