tustvold commented on code in PR #2578:
URL: https://github.com/apache/arrow-datafusion/pull/2578#discussion_r884336279


##########
datafusion/core/src/physical_plan/file_format/mod.rs:
##########
@@ -68,6 +70,8 @@ lazy_static! {
 pub struct FileScanConfig {
     /// Store from which the `files` should be fetched
     pub object_store: Arc<dyn ObjectStore>,
+    /// Object store URL
+    pub object_store_url: ObjectStoreUrl,

Review Comment:
   This was the solution I came up with to allow ballista to round-trip the 
physical plan, store a canonical ObjectStoreUrl instead of relying on the files 
to contain the scheme.
   
    I think perhaps in a subsequent PR I'll try to remove the `object_store` 
member which is now redundant.
   
   FYI @thinkharderdev 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to