[GitHub] [arrow] sanjibansg commented on a diff in pull request #13285: ARROW-15582: [C++] Add support for registering tricky functions with the Substrait consumer (or add a bunch of substrait meta functions)

[GitBox]

sanjibansg commented on code in PR #13285:
URL: https://github.com/apache/arrow/pull/13285#discussion_r887532254


##########
cpp/src/arrow/engine/substrait/expression_internal.cc:
##########
@@ -159,21 +159,11 @@ Result<compute::Expression> FromProto(const 
substrait::Expression& expr,
 
       ARROW_ASSIGN_OR_RAISE(auto decoded_function,
                             
ext_set.DecodeFunction(scalar_fn.function_reference()));
+      
+      auto arrow_function = 
ext_set.functions_map.GetArrowFromSubstrait(static_cast<std::string>(decoded_function.name));

Review Comment:
   Can use `to_string()` here



##########
cpp/src/arrow/engine/substrait/extension_set.h:
##########
@@ -228,6 +250,8 @@ class ARROW_ENGINE_EXPORT ExtensionSet {
   /// future; see ARROW-15583.
   std::size_t num_functions() const { return functions_.size(); }
 
+  arrow::engine::FunctionMapping functions_map;

Review Comment:
   Will keep this in Extension Registry



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org