alamb commented on code in PR #1819:
URL: https://github.com/apache/arrow-rs/pull/1819#discussion_r892360650
##########
arrow/src/datatypes/native.rs:
##########
@@ -19,6 +19,10 @@ use super::DataType;
use half::f16;
use serde_json::{Number, Value};
+mod private {
+ pub trait Sealed {}
Review Comment:
I think we should add some docstrings about *why* it is not allowed to
ArrowNativeType
Using the text from the PR description "ArrowNativeType is used to indicate
"trivially safely transmutable" within the buffer implementations. If client
can create their own implementations they can do potentially unwise things."
would be a good starting point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
