jhorstmann commented on code in PR #1819:
URL: https://github.com/apache/arrow-rs/pull/1819#discussion_r892529479
##########
arrow/src/datatypes/native.rs:
##########
@@ -351,8 +382,11 @@ impl JsonSerializable for f64 {
}
impl ArrowNativeType for f16 {}
+impl private::Sealed for f16 {}
impl ArrowNativeType for f32 {}
+impl private::Sealed for f32 {}
impl ArrowNativeType for f64 {}
+impl private::Sealed for f64 {}
/// Allows conversion from supported Arrow types to a byte slice.
pub trait ToByteSlice {
Review Comment:
The `ToByteSlice` trait would also be a candiate for sealing as it also used
for transmuting and should only be used on ArrowNativeTypes and slices of
ArrowNativeType.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
