jhorstmann commented on code in PR #1819:
URL: https://github.com/apache/arrow-rs/pull/1819#discussion_r892557312
##########
arrow/src/datatypes/native.rs:
##########
@@ -351,8 +382,11 @@ impl JsonSerializable for f64 {
}
impl ArrowNativeType for f16 {}
+impl private::Sealed for f16 {}
impl ArrowNativeType for f32 {}
+impl private::Sealed for f32 {}
impl ArrowNativeType for f64 {}
+impl private::Sealed for f64 {}
/// Allows conversion from supported Arrow types to a byte slice.
pub trait ToByteSlice {
Review Comment:
Right, I did not word that right. The question is rather whether we want to
support other (external) types to be used for example in `MutableBuffer`:
```
pub fn push<T: ToByteSlice>(&mut self, item: T)
```
It's probably fine as it would only be unsound if the trait impl does
something explicitly unsound.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
