tustvold commented on code in PR #1819:
URL: https://github.com/apache/arrow-rs/pull/1819#discussion_r892459671
##########
arrow/src/datatypes/native.rs:
##########
@@ -19,6 +19,10 @@ use super::DataType;
use half::f16;
use serde_json::{Number, Value};
+mod private {
+ pub trait Sealed {}
Review Comment:
I think I prefer implementing it with the rest of the implementations for
the type. It makes it clearer why it is implemented, and theoretically we may
macroify it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
