drin commented on code in PR #13383:
URL: https://github.com/apache/arrow/pull/13383#discussion_r898277387
##########
cpp/src/arrow/record_batch.cc:
##########
@@ -393,7 +393,7 @@ Result<std::shared_ptr<RecordBatchReader>>
RecordBatchReader::Make(
RecordBatchReader::~RecordBatchReader() {
auto st = this->Close();
if (!st.ok()) {
- ARROW_LOG(WARNING) << "Implicitly called RecordBatchReader::Close failed:
" << st;
+ st.Warn("Implicitly called RecordBatchReader::Close failed");
Review Comment:
I meant to ask earlier: if `ARROW_WARN_NOT_OK` only takes an expr, then to
print a custom message you need to call `Warn()` directly; should I add another
macro, something like `ARROW_WARN_MSG_NOT_OK` to also take a message, or should
we drop that custom message?
I assume you can't overload a macro, not sure if there's a preference on an
approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
