lidavidm commented on code in PR #13383:
URL: https://github.com/apache/arrow/pull/13383#discussion_r898311816
##########
cpp/src/arrow/record_batch.cc:
##########
@@ -393,7 +393,7 @@ Result<std::shared_ptr<RecordBatchReader>>
RecordBatchReader::Make(
RecordBatchReader::~RecordBatchReader() {
auto st = this->Close();
if (!st.ok()) {
- ARROW_LOG(WARNING) << "Implicitly called RecordBatchReader::Close failed:
" << st;
+ st.Warn("Implicitly called RecordBatchReader::Close failed");
Review Comment:
Ah, right. Since the current macro isn't used in many places I would be in
favor of just making the macro always require a message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
