drin commented on code in PR #13583:
URL: https://github.com/apache/arrow/pull/13583#discussion_r922342414
##########
cpp/src/arrow/util/hashing.h:
##########
@@ -485,6 +485,20 @@ class ScalarMemoTable : public MemoTable {
hash_t ComputeHash(const Scalar& value) const {
return ScalarHelper<Scalar, 0>::ComputeHash(value);
}
+
+ public:
+ // defined here so that `HashTableType` is visible
+ // Merge entries from `other_table` into `this->hash_table_`.
+ Status MergeTable(ScalarMemoTable& other_table) {
+ HashTableType& other_hashtable = other_table.hash_table_;
+
+ other_hashtable.VisitEntries([this](const HashTableEntry* other_entry) {
+ int32_t unused;
+ DCHECK_OK(this->GetOrInsert(other_entry->payload.value, &unused));
+ });
+ // TODO: implement proper (and perhaps more performant) error handling
Review Comment:
oh yeah, good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
