wesm commented on code in PR #13583:
URL: https://github.com/apache/arrow/pull/13583#discussion_r921123551
##########
cpp/src/arrow/util/hashing.h:
##########
@@ -428,6 +428,22 @@ class ScalarMemoTable : public MemoTable {
value, [](int32_t i) {}, [](int32_t i) {}, out_memo_index);
}
+ Status MaybeInsert(const Scalar& value) {
Review Comment:
Indeed, the empty closures will be easily optimized away by the compiler as
dead / side-effect-free code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
