cyb70289 commented on code in PR #13583:
URL: https://github.com/apache/arrow/pull/13583#discussion_r920638291
##########
cpp/src/arrow/util/hashing.h:
##########
@@ -428,6 +428,22 @@ class ScalarMemoTable : public MemoTable {
value, [](int32_t i) {}, [](int32_t i) {}, out_memo_index);
}
+ Status MaybeInsert(const Scalar& value) {
Review Comment:
Wrapping with a new API looks more clear.
I'm not worried about the empty closures and dummy return value. Probably
compiler will optimize them to nothing if it decides to inline `GetOrInsert` as
it's small.
A quick example, there's no unnecessary function calls or value assignments
https://godbolt.org/z/TjjTxzz8j
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
