cyb70289 commented on code in PR #13583:
URL: https://github.com/apache/arrow/pull/13583#discussion_r920640160
##########
cpp/src/arrow/util/hashing.h:
##########
@@ -824,6 +898,13 @@ class BinaryMemoTable : public MemoTable {
};
return hash_table_.Lookup(h, cmp_func);
}
+
+ public:
+ void MergeTable(BinaryMemoTable& other_table) {
+ other_table.VisitValues(0, [=](const util::string_view& other_value) {
Review Comment:
Capture all by value looks not good, and I think only `this` is to be
captured.
##########
cpp/src/arrow/util/hashing.h:
##########
@@ -824,6 +898,13 @@ class BinaryMemoTable : public MemoTable {
};
return hash_table_.Lookup(h, cmp_func);
}
+
+ public:
+ void MergeTable(BinaryMemoTable& other_table) {
+ other_table.VisitValues(0, [=](const util::string_view& other_value) {
Review Comment:
Capture all by value looks not good, and I think only `this` is to be
captured here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
