tustvold commented on code in PR #2906:
URL: https://github.com/apache/arrow-datafusion/pull/2906#discussion_r922646809
##########
datafusion/core/src/datasource/object_store.rs:
##########
@@ -132,19 +149,51 @@ impl ObjectStoreRegistry {
///
/// - URL with scheme `file:///` or no schema will return the default
LocalFS store
/// - URL with scheme `s3://bucket/` will return the S3 store if it's
registered
+ /// - URL with scheme `hdfs://hostname:port` will return the hdfs store if
it's registered
///
pub fn get_by_url(&self, url: impl AsRef<Url>) -> Result<Arc<dyn
ObjectStore>> {
let url = url.as_ref();
- let s = &url[url::Position::BeforeScheme..url::Position::AfterHost];
- let stores = self.object_stores.read();
- let store = stores.get(s).ok_or_else(|| {
- DataFusionError::Internal(format!(
- "No suitable object store found for {}",
- url
- ))
- })?;
-
- Ok(store.clone())
+ // First check whether can get object store from registry
+ let store = {
+ let stores = self.object_stores.read();
+ let s =
&url[url::Position::BeforeScheme..url::Position::BeforeHost];
Review Comment:
Could you perhaps expand on the threat model here, and how this would impact
it. If the user has opted to use HTTP Basic Auth, I don't see how storing that
data in memory as part of the URL is avoidable...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
