tustvold commented on code in PR #2906:
URL: https://github.com/apache/arrow-datafusion/pull/2906#discussion_r922871773
##########
datafusion/core/src/datasource/object_store.rs:
##########
@@ -81,10 +81,19 @@ impl std::fmt::Display for ObjectStoreUrl {
}
}
+/// Object store provider can detector an object store based on the url
+pub trait ObjectStoreProvider: Send + Sync + 'static {
+ /// Detector a suitable object store based on its url if possible
+ /// Return the key and object store
+ fn get_by_url(&self, url: &Url) -> Option<(String, Arc<dyn ObjectStore>)>;
Review Comment:
I'm not sure how this returning of a `String` is intended to work, as it
will always be looked up in the hashmap based on
`&url[url::Position::BeforeScheme..url::Position::BeforePath];`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
