yahoNanJing commented on code in PR #2906:
URL: https://github.com/apache/arrow-datafusion/pull/2906#discussion_r922924034
##########
datafusion/core/src/datasource/object_store.rs:
##########
@@ -81,10 +81,19 @@ impl std::fmt::Display for ObjectStoreUrl {
}
}
+/// Object store provider can detector an object store based on the url
+pub trait ObjectStoreProvider: Send + Sync + 'static {
+ /// Detector a suitable object store based on its url if possible
+ /// Return the key and object store
+ fn get_by_url(&self, url: &Url) -> Option<(String, Arc<dyn ObjectStore>)>;
Review Comment:
You are right. With the new logic of get_by_url, we can just use the key as
the parameter and the returned value without the String key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
