tustvold commented on code in PR #2906:
URL: https://github.com/apache/arrow-datafusion/pull/2906#discussion_r923331588


##########
datafusion/core/src/catalog/schema.rs:
##########
@@ -162,7 +162,17 @@ mod tests {
     #[tokio::test]
     async fn test_schema_register_listing_table() {
         let testdata = crate::test_util::parquet_test_data();
-        let filename = format!("file:///{}/{}", testdata, 
"alltypes_plain.parquet");
+        let testdir = if testdata.starts_with('/') {

Review Comment:
   I wonder if this logic would be better handled in get_data_dir (to remove 
any trailing /)? As it stands I'm surprised just making this change here is 
sufficient?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to