tustvold commented on code in PR #2906:
URL: https://github.com/apache/arrow-datafusion/pull/2906#discussion_r923329407
##########
datafusion/core/src/execution/runtime_env.rs:
##########
@@ -121,6 +122,8 @@ pub struct RuntimeConfig {
pub disk_manager: DiskManagerConfig,
/// MemoryManager to limit access to memory
pub memory_manager: MemoryManagerConfig,
+ /// ObjectStoreRegistry to get object store based on url
+ pub object_store_registry: ObjectStoreRegistry,
Review Comment:
Two reasons:
* We use `Arc<ObjectStoreRegistry>` elsewhere and so using it here is more
consistent
* It provides a hint that this is shared state, e.g. we use
`Arc<DiskManager>` instead of just `DiskManager`, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
