icexelloss commented on code in PR #13644:
URL: https://github.com/apache/arrow/pull/13644#discussion_r924732755
##########
cpp/src/arrow/compute/exec/asof_join_node.cc:
##########
@@ -478,6 +481,23 @@ class CompositeReferenceTable {
ARROW_RETURN_NOT_OK(builder.Finish(&result));
return result;
}
+
+ template <class Builder, class PrimitiveType>
+ Result<std::shared_ptr<Array>> MaterializePrimitiveColumn(MemoryPool*
memory_pool,
+ size_t i_table,
+ col_index_t i_col)
{
+ Builder builder(memory_pool);
+ return MaterializePrimitiveColumn<Builder, PrimitiveType>(builder,
i_table, i_col);
+ }
+
+ template <class PrimitiveType>
+ Result<std::shared_ptr<Array>> MaterializeTimestampPrimitiveColumn(
+ MemoryPool* memory_pool, size_t i_table, col_index_t i_col) {
+ TimestampBuilder builder =
+ TimestampBuilder(timestamp(TimeUnit::NANO, "UTC"), memory_pool);
Review Comment:
Can you not hardcode the timezone here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
