iChauster commented on code in PR #13644:
URL: https://github.com/apache/arrow/pull/13644#discussion_r924766062
##########
cpp/src/arrow/compute/exec/asof_join_node.cc:
##########
@@ -630,24 +650,28 @@ class AsofJoinNode : public ExecNode {
for (int i = 0; i < input_schema->num_fields(); ++i) {
const auto field = input_schema->field(i);
if (field->name() == on_field_name) {
- if (kSupportedOnTypes_.find(field->type()) ==
kSupportedOnTypes_.end()) {
- return Status::Invalid("Unsupported type for on key: ",
field->name());
+ // Equals must be used when checking for timestamp types.
+ if (!field->type()->Equals(TimestampType(TimeUnit::NANO, "UTC")) &&
Review Comment:
e.g, even though I have added `TimestampType` to `kSupportedOnTypes_`, it
has no effect, and is not found in the array. I looked for a more generic way
to detect a `TimestampType`, like `arrow::istimestamp_type` in
`src/arrow/type_traits.h` but I'm not sure how it works with the templating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
