icexelloss commented on PR #13644: URL: https://github.com/apache/arrow/pull/13644#issuecomment-1189322585
@iChauster You are missing test for this change. Please add test in asof_join_test file. I think it's ok to only allow "timestamp" type instead of supporting both "long" and "timestamp" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
