iChauster commented on code in PR #13644:
URL: https://github.com/apache/arrow/pull/13644#discussion_r924771462
##########
cpp/src/arrow/compute/exec/asof_join_node.cc:
##########
@@ -460,10 +464,9 @@ class CompositeReferenceTable {
}
template <class Builder, class PrimitiveType>
- Result<std::shared_ptr<Array>> MaterializePrimitiveColumn(MemoryPool*
memory_pool,
+ Result<std::shared_ptr<Array>> MaterializePrimitiveColumn(Builder& builder,
Review Comment:
Was fighting with the compiler for a bit on this:
`TimestampBuilder` does not seem to be able to initialized with just a
`memory_pool`, I think it requires a `arrow::DataType` object as well. That is
the only difference that requires this function to be refactored and split into
`MaterializePrimitveColumn` and `MaterializeTimestampPrimitiveColumn`.
Everything downstream of the builder initialization is the same -- let me
know if there is a better way to handle this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
