westonpace commented on code in PR #13613:
URL: https://github.com/apache/arrow/pull/13613#discussion_r933394240
##########
cpp/src/arrow/engine/substrait/ext_test.cc:
##########
@@ -198,11 +207,11 @@ TEST(ExtensionIdRegistryTest, RegisterTempFunctions) {
for (util::string_view name : kTempFunctionNames) {
Review Comment:
I linked an article earlier that talks about why it is better to pass
`util::string_view` by value. I find it is helpful to think of `string_view`
as just a specialized `char*`. So I wouldn't do `const char*& name` and I
don't do `const util::string_view& name`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
