westonpace commented on code in PR #13613:
URL: https://github.com/apache/arrow/pull/13613#discussion_r933396684
##########
cpp/src/arrow/compute/exec/util.cc:
##########
@@ -383,5 +383,25 @@ size_t ThreadIndexer::Check(size_t thread_index) {
return thread_index;
}
+Status TableSinkNodeConsumer::Init(const std::shared_ptr<Schema>& schema,
+ BackpressureControl* backpressure_control) {
+ // If the user is collecting into a table then backpressure is meaningless
Review Comment:
The `SinkNodeConsumer` objects can be useful to add to the public API
because users specify them as part of options. That's why I had to move this
one since the previous location wasn't public and I couldn't use it in tests.
The `TableSourceNode` is a node and those stay in the private API so I don't
think we need to move that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
