westonpace commented on code in PR #13613:
URL: https://github.com/apache/arrow/pull/13613#discussion_r938342557
##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -703,6 +703,11 @@ TEST(Substrait, ExtensionSetFromPlan) {
"extension_uri_anchor": 7,
"uri": ")" + substrait::default_extension_types_uri() +
R"("
+ },
+ {
+ "extension_uri_anchor": 18,
+ "uri": ")" + std::string(kSubstraitArithmeticFunctionsUri) +
Review Comment:
I considered adding these functions but, at the end of the day, this is
information that the caller should be getting from Substrait and I don't know
if Arrow needs to provide them. I don't want to hold up this PR on this so we
still think these functions are needed we can create a follow-up PR and have
the discussion there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
