tustvold commented on code in PR #2303:
URL: https://github.com/apache/arrow-rs/pull/2303#discussion_r936614065
##########
arrow/src/buffer/immutable.rs:
##########
@@ -77,30 +76,6 @@ impl Buffer {
Buffer::build_with_arguments(ptr, len, Deallocation::Arrow(capacity))
}
- /// Creates a buffer from an existing memory region (must already be
byte-aligned), this
- /// `Buffer` **does not** free this piece of memory when dropped.
- ///
- /// # Arguments
- ///
- /// * `ptr` - Pointer to raw parts
- /// * `len` - Length of raw parts in **bytes**
- /// * `data` - An [crate::ffi::FFI_ArrowArray] with the data
- ///
- /// # Safety
- ///
- /// This function is unsafe as there is no guarantee that the given
pointer is valid for `len`
- /// bytes and that the foreign deallocator frees the region.
- #[deprecated(
- note = "use from_custom_allocation instead which makes it clearer that
the allocation is in fact owned"
- )]
- pub unsafe fn from_unowned(
Review Comment:
This method was already deprecated, so I opted to just remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
