tustvold commented on code in PR #2303:
URL: https://github.com/apache/arrow-rs/pull/2303#discussion_r936614642
##########
arrow/src/ffi.rs:
##########
@@ -836,10 +838,11 @@ impl<'a> ArrowArrayRef for ArrowArrayChild<'a> {
impl ArrowArray {
/// creates a new `ArrowArray`. This is used to export to the C Data
Interface.
- /// # Safety
- /// See safety of [ArrowArray]
- #[allow(clippy::too_many_arguments)]
- pub unsafe fn try_new(data: ArrayData) -> Result<Self> {
+ ///
+ /// # Memory Leaks
+ /// This method releases `buffers`. Consumers of this struct *must* call
`release` before
+ /// releasing this struct, or contents in `buffers` leak.
+ pub fn try_new(data: ArrayData) -> Result<Self> {
Review Comment:
This method wasn't actually unsafe, and was being called by safe methods
previously without any additional checks #2301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
