tustvold commented on code in PR #2303:
URL: https://github.com/apache/arrow-rs/pull/2303#discussion_r936616676
##########
arrow/src/array/array.rs:
##########
@@ -216,15 +214,6 @@ pub trait Array: fmt::Debug + Send + Sync + JsonEqual {
self.data_ref().get_array_memory_size() + std::mem::size_of_val(self)
- std::mem::size_of::<ArrayData>()
}
-
- /// returns two pointers that represent this array in the C Data Interface
(FFI)
- fn to_raw(
Review Comment:
I didn't see a compelling reason for this API to exist, ultimately the use
of `std::any::Any` means users can't implement `Array` for custom types, and I
can't see why arrow-rs would ever make use of this extension point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
