alamb commented on code in PR #2303: URL: https://github.com/apache/arrow-rs/pull/2303#discussion_r937129783
########## arrow/Cargo.toml: ########## @@ -72,14 +72,16 @@ prettyprint = ["comfy-table"] # an optional dependency for supporting compile to wasm32-unknown-unknown # target without assuming an environment containing JavaScript. test_utils = ["rand"] -pyarrow = ["pyo3"] +pyarrow = ["pyo3", "ffi"] # force_validate runs full data validation for all arrays that are created # this is not enabled by default as it is too computationally expensive # but is run as part of our CI checks force_validate = [] +# Enable ffi support +ffi = [] Review Comment: 🤔 I was going to recommend adding this to the "list of features of this crate" but then it turns out we don't seem to have any docs for them 🤦 https://docs.rs/arrow/19.0.0/arrow/ ########## arrow/src/array/array.rs: ########## @@ -216,15 +214,6 @@ pub trait Array: fmt::Debug + Send + Sync + JsonEqual { self.data_ref().get_array_memory_size() + std::mem::size_of_val(self) - std::mem::size_of::<ArrayData>() } - - /// returns two pointers that represent this array in the C Data Interface (FFI) - fn to_raw( Review Comment: I do not feel comfortable reviewing this change -- I think @viirya / @kszucs may know more about its usecase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
