westonpace commented on code in PR #13932:
URL: https://github.com/apache/arrow/pull/13932#discussion_r950611828
##########
cpp/src/arrow/filesystem/localfs_benchmark.cc:
##########
@@ -66,7 +66,7 @@ class LocalFSFixture : public benchmark::Fixture {
arrow::internal::PlatformFilename
cur_root_dir) {
ASSERT_OK(arrow::internal::CreateDir(cur_root_dir));
- arrow::internal::StringFormatter<Int32Type> format;
+ arrow::internal::StringFormatter<DoubleType> format;
Review Comment:
Is `DoubleType` correct? Isn't size_t `Int64Type`? I'm not actually sure
if `size_t`'s width is guaranteed. So maybe something like...
```
for (size_t i = 0; i < num_files_; ++i) {
...
format(static_cast<int64_t>(i), ...);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
