ManManson commented on code in PR #13932:
URL: https://github.com/apache/arrow/pull/13932#discussion_r951076256
##########
cpp/src/arrow/filesystem/localfs_benchmark.cc:
##########
@@ -66,7 +66,7 @@ class LocalFSFixture : public benchmark::Fixture {
arrow::internal::PlatformFilename
cur_root_dir) {
ASSERT_OK(arrow::internal::CreateDir(cur_root_dir));
- arrow::internal::StringFormatter<Int32Type> format;
+ arrow::internal::StringFormatter<DoubleType> format;
Review Comment:
Since this should be a one-liner change either way, refusing to get a free
performance boost by swapping to a `std::stringstream` is somewhat illogical :)
I propose we just cast to `int64_t/uint64_t` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
