HaoYang670 commented on code in PR #3522:
URL: https://github.com/apache/arrow-datafusion/pull/3522#discussion_r973523325
##########
datafusion/core/src/config.rs:
##########
@@ -291,6 +291,10 @@ impl ConfigOptions {
pub fn get_bool(&self, key: &str) -> bool {
match self.get(key) {
Some(ScalarValue::Boolean(Some(b))) => b,
+ Some(b) => b
Review Comment:
Agreed with @andygrove. It would be better to make the configuration
dynamically and strongly typed:
```rust
pub fn get_bool(&self, key: &str) -> Result<bool> {
match self.get(key) {
Some(ScalarValue::Boolean(Some(b))) => b,
Some(_) => Err(DatafusionError("The configuration {} is not a
Boolean")),
None => Err(DatafusionError("The configuration {} is not set")),
}}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
