HaoYang670 commented on PR #3522: URL: https://github.com/apache/arrow-datafusion/pull/3522#issuecomment-1250053460
> if they key doesn't exist should we return Err or default value Personally, I prefer returning an error, because it tells users what has happened (a get_before_set error). And users can customize the error in their ways. > whereas reader has no idea what the type by selected key is in the config I guess this assumption is somewhat unrealistic. How could a reader use the config if he/she doesn't know the type of it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
