comphead commented on PR #3522: URL: https://github.com/apache/arrow-datafusion/pull/3522#issuecomment-1250064629
> > if they key doesn't exist should we return Err or default value > > Personally, I prefer returning an error, because it tells users what has happened (a get_before_set error). And users can customize the error in their ways. > > > whereas reader has no idea what the type by selected key is in the config > > I guess this assumption is somewhat unrealistic. How could a reader use the config if he/she doesn't know the type of it? Hi @HaoYang670, thanks for pointing out on this. That makes sense. If we consider spark config, which supports both initial and runtime config params, there all values are strings. The end user casts the config value to the type he needs on his side. So my concern here, if we support not only documented params, but also custom/runtime params then is this scenario real, that someone sets a custom param, and a reader without knowing a correct type in config will have go through all supported types until he finds the correct one? @andygrove ^^^^ If its not the case, then making values strongly typed on set is good idea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
