comphead commented on PR #3522:
URL:
https://github.com/apache/arrow-datafusion/pull/3522#issuecomment-1250001762
@andygrove @HaoYang670 Thank you for comments.
I like the idea to return `Result<T>` from all `get` methods.
however there are some things to discuss.
- if they key doesn't exist should we return `Err` or default value?
- if the types doesn't match but castable on `get`, should we fail or cast
if possible? cast on set perhaps not good idea as user that sets configs
usually knows the type to put to the config store and can select correct set
method, whereas reader has no idea what the type by selected key is in the
config. Thus I think cast on read is more useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
