tustvold commented on code in PR #4522:
URL: https://github.com/apache/arrow-datafusion/pull/4522#discussion_r1040142324
##########
datafusion/core/tests/order_spill_fuzz.rs:
##########
@@ -110,12 +107,23 @@ async fn run_sort(pool_size: usize, size_spill:
Vec<(usize, bool)>) {
/// with randomized i32 content
fn make_staggered_batches(len: usize) -> Vec<RecordBatch> {
let mut rng = rand::thread_rng();
- let mut input: Vec<i32> = vec![0; len];
- rng.fill(&mut input[..]);
- let input = Int32Array::from_iter_values(input.into_iter());
-
- // split into several record batches
- let batch =
- RecordBatch::try_from_iter(vec![("x", Arc::new(input) as
ArrayRef)]).unwrap();
- stagger_batch_with_seed(batch, 42)
+ let max_batch = 1024;
Review Comment:
Again, slicing batches causes the memory limiter to fail as it doesn't
consider array slicing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
