tustvold commented on code in PR #4522:
URL: https://github.com/apache/arrow-datafusion/pull/4522#discussion_r1040143299
##########
datafusion/core/src/physical_plan/metrics/tracker.rs:
##########
@@ -118,14 +103,3 @@ impl MemTrackingMetrics {
self.metrics.record_poll(poll)
}
}
-
-impl Drop for MemTrackingMetrics {
- fn drop(&mut self) {
- self.metrics.try_done();
Review Comment:
This is redundant as the Drop of `BaselineMetrics` already calls this
##########
datafusion/core/src/physical_plan/metrics/tracker.rs:
##########
@@ -118,14 +103,3 @@ impl MemTrackingMetrics {
self.metrics.record_poll(poll)
}
}
-
-impl Drop for MemTrackingMetrics {
- fn drop(&mut self) {
- self.metrics.try_done();
- if self.mem_used() != 0 {
Review Comment:
This is no longer needed as TrackedAllocation does it automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
