tustvold commented on code in PR #4522:
URL: https://github.com/apache/arrow-datafusion/pull/4522#discussion_r1040142986
##########
datafusion/core/src/physical_plan/sorts/sort.rs:
##########
@@ -73,17 +70,18 @@ use tokio::task;
/// buffer the batch in memory, go to 1.
/// 3. when input is exhausted, merge all in memory batches and spills to get
a total order.
struct ExternalSorter {
- id: MemoryConsumerId,
schema: SchemaRef,
- in_mem_batches: Mutex<Vec<BatchWithSortArray>>,
Review Comment:
This Mutex aren't actually needed, took the opportunity to just remove them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
