tustvold commented on code in PR #4645:
URL: https://github.com/apache/arrow-datafusion/pull/4645#discussion_r1049541427
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -179,22 +212,19 @@ impl Optimizer {
Arc::new(EliminateLimit::new()),
Arc::new(PropagateEmptyRelation::new()),
Arc::new(RewriteDisjunctivePredicate::new()),
+ Arc::new(FilterNullJoinKeys::default()),
+ Arc::new(EliminateOuterJoin::new()),
+ // Filters can't be pushed down past Limits, we should do
PushDownFilter after LimitPushDown
+ Arc::new(PushDownLimit::new()),
+ Arc::new(PushDownFilter::new()),
+ Arc::new(SingleDistinctToGroupBy::new()),
+ // The previous optimizations added expressions and projections,
+ // that might benefit from the following rules
+ Arc::new(SimplifyExpressions::new()),
+ Arc::new(UnwrapCastInComparison::new()),
+ Arc::new(CommonSubexprEliminate::new()),
+ Arc::new(PushDownProjection::new()),
];
- if config.filter_null_keys {
Review Comment:
This is the other half of the fix for #4638 - determine the rules dynamically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
