tustvold commented on code in PR #4645:
URL: https://github.com/apache/arrow-datafusion/pull/4645#discussion_r1049542092
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -54,33 +55,53 @@ pub trait OptimizerRule {
fn try_optimize(
&self,
plan: &LogicalPlan,
- optimizer_config: &mut OptimizerConfig,
+ config: &dyn OptimizerConfig,
) -> Result<Option<LogicalPlan>> {
- self.optimize(plan, optimizer_config).map(Some)
+ self.optimize(plan, config).map(Some)
}
/// Rewrite `plan` to an optimized form. This method will eventually be
deprecated and
/// replace by `try_optimize`.
fn optimize(
&self,
plan: &LogicalPlan,
- optimizer_config: &mut OptimizerConfig,
+ config: &dyn OptimizerConfig,
) -> Result<LogicalPlan>;
/// A human readable name for this optimizer rule
fn name(&self) -> &str;
}
/// Options to control the DataFusion Optimizer.
+pub trait OptimizerConfig {
+ /// Return the time at which the query execution started. This
+ /// time is used as the value for now()
+ fn query_execution_start_time(&self) -> DateTime<Utc>;
+
+ /// Returns false if the given rule should be skipped
+ fn rule_enabled(&self, name: &str) -> bool;
Review Comment:
I felt this formulation was more future proof than adding a specific
function for enabling/disabling `FilterNullJoins`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
