tustvold commented on code in PR #4645:
URL: https://github.com/apache/arrow-datafusion/pull/4645#discussion_r1049544255
##########
datafusion/core/src/execution/context.rs:
##########
@@ -1741,32 +1733,37 @@ impl SessionState {
/// Optimizes the logical plan by applying optimizer rules.
pub fn optimize(&self, plan: &LogicalPlan) -> Result<LogicalPlan> {
- let mut optimizer_config = OptimizerConfig::new()
- .with_skip_failing_rules(
- self.config
- .config_options
- .read()
- .get_bool(OPT_OPTIMIZER_SKIP_FAILED_RULES)
- .unwrap_or_default(),
- )
- .with_max_passes(
- self.config
- .config_options
- .read()
- .get_u64(OPT_OPTIMIZER_MAX_PASSES)
- .unwrap_or_default() as u8,
- )
- .with_query_execution_start_time(
- self.execution_props.query_execution_start_time,
- );
+ // TODO: Implement OptimizerContext directly on DataFrame (#4631)
(#4626)
Review Comment:
This is the ultimate motivation for this change, to allow a single config
container, that then just implements the traits needed by the various
sub-systems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
