tustvold commented on code in PR #4645:
URL: https://github.com/apache/arrow-datafusion/pull/4645#discussion_r1049542527
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -89,12 +110,12 @@ pub struct OptimizerConfig {
max_passes: u8,
}
-impl OptimizerConfig {
+impl OptimizerContext {
/// Create optimizer config
pub fn new() -> Self {
Self {
query_execution_start_time: Utc::now(),
- next_id: 0, // useful for generating things like unique subquery
aliases
+ next_id: AtomicUsize::new(1),
Review Comment:
We use 1, as previously the implementation returned the value post-increment
which the atomics don't provide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
