ozankabak commented on PR #4616: URL: https://github.com/apache/arrow-datafusion/pull/4616#issuecomment-1353623877
> Supporting `retract_batch` on the existing `min` / `max` aggregators in https://github.com/apache/arrow-datafusion/blob/master/datafusion/physical-expr/src/aggregate/min_max.rs is probably a bad idea as it will slow down the non-window version > > I wonder if it would be possible to make new accumulators that did support retract batch and use them instead of `MinAccumulator` and `MaxAccumulator` when operating on bounded window functions Agreed, this makes sense. Planner can choose which version to use depending on the query. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
