alamb commented on PR #4616: URL: https://github.com/apache/arrow-datafusion/pull/4616#issuecomment-1353628787
> I think implementation in this https://github.com/synnada-ai/arrow-datafusion/pull/29 is better design for future (both in terms of algorithmic complexity[it is an amortized constant algorithm and uses finite memory] and readability). @alamb What do you think about this discussion? I don't have any strong opinion on the specific data structure used. My ideal workflow is: 1. Whoever contributes the code initially gets to decide on the initial algorithm 2. The initial PR includes sufficient tests that ensure subsequent algorithmic improvements remain correct 3. We accept follow on PRs to improve the algorithms that show improved performance in benchmarks Does that make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
