alamb commented on pull request #8402:
URL: https://github.com/apache/arrow/pull/8402#issuecomment-715419232


   
   > Not really, because I am using the `cast` kernels in the `Converter`: 
[`4b59fc9` 
(#8402)](https://github.com/apache/arrow/pull/8402/commits/4b59fc952336bee757cf27ae596b56edbccf099a#diff-1c415d3e7b8a0ac89a3b07a88aaf2d1f4a3c0c289233440776be1f76f846b7d5R307-R344)
 in the style of the other converters in that file
   
   That code seems to be using `cast` as part of the implementation of casting 
dictionary keys, very similar to the way cast does internally: 
https://github.com/apache/arrow/blob/master/rust/arrow/src/compute/kernels/cast.rs#L979-L982
   
   I was trying to suggest rather than making some sort of generic `Convert<>` 
function  there was a function like:
   
   ```convert_parquet_column(col_iter) --> ArrayRef```
   
   Where the choice of type for `ArrayRef` is *entirely* based on the type of 
`col_iter` (the parquet type, not the desired arrow type). And then use the 
`cast` kernel to go to the specific Arrow type that is needed
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to